Skip to content

[DNR][WIP] 🌱 Testing Timeout fix for CAPI v1.11 clusterclass-changes #5756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrischdi wants to merge 42 commits into from
Closed

[DNR][WIP] 🌱 Testing Timeout fix for CAPI v1.11 clusterclass-changes #5756

chrischdi wants to merge 42 commits into from

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Nov 20, 2025

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Tests the CAPI PR:

Via branch (based on v1.11.1, not CAPI main as the actual PR):

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE
bryan-cox and others added 30 commits November 14, 2025 17:42
@bryan-cox @clebs
deps: upgrade Kubernetes dependencies to v0.33.4
432afd8 
- Update core Kubernetes dependencies from v0.32.3 to v0.33.4: - k8s.io/api, k8s.io/apimachinery, k8s.io/client-go - k8s.io/apiserver, k8s.io/cli-runtime, k8s.io/kubectl - k8s.io/apiextensions-apiserver, k8s.io/component-base - Upgrade prometheus/client_golang from v1.19.1 to v1.22.0 - Update cel.dev/expr from v0.18.0 to v0.19.1 - Upgrade google/cel-go from v0.22.0 to v0.23.2 - Update golang.org/x/time from v0.8.0 to v0.9.0 - Upgrade gRPC from v1.67.3 to v1.68.1 - Update OpenTelemetry packages to v1.33.0 - Refresh k8s.io/utils and other indirect dependencies - Update kube-openapi and structured-merge-diff versions
@bryan-cox @clebs
deps: update cluster-api to v1.11.1 and controller-runtime to v0.21.0
6c277a3 
- Upgrade cluster-api from v1.10.2 to v1.11.1 - Upgrade controller-runtime from v0.20.4 to v0.21.0 - Update various golang.org/x/* packages - Update testing dependencies (ginkgo, gomega) - Update OpenTelemetry and other indirect dependencies
@bryan-cox @clebs
WIP no IDE errors
cef8a4d
@bryan-cox @clebs
WIP IDE Errors
e5f0d8f
@clebs
Fix go dependencies
454cc67 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Update imports, code and generations to CAPI 1.11
ce62bbc 
- Update all imports to v1beta2 types except for conditions staying in v1beta1. - Adapt source code to work with v1beta2 and deprecated conditions. - Manually update conversions. Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Update linting pkg alias and fix broken imports blocks
0b8bf56 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Remove unnecessary Paused constants
1491bcb 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Fix import aliases
d35c4ab 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Fix broken imports
bd9f9f4 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Revert public APIS back to v1beta1 while internally using v1beta2
5ad2783 
Introducing v1beta2 on public types is a breaking change so they have to stay in v1beta1. Internally though, migration to v1beta2 is happening (except for conditions). Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Revert infrav1 conditions to v1beta1 and consolidate imports
6c66522 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Consolidate conditions imports and fix linting
3a3dc37 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Fix regression in machine deployments without failure domain set
54e4777 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Revert missing public APIs to v1beta1
dcc5efe 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Consolidate infrav1beta1 imports into infrav1
71840b7 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Remove unused conditions constants
8ad6446 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Fix setting wrong condition type
4c5e489 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Cast v1beta1 conditions instead of creating a new constant
6944e51 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Revert changed public APIs and adapt internally to v1beta2
d329175 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Resolve conflicts with main
fd6e22a 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Add deprecated CAPI imports linter rule
e3e4196 
Add rule to allow using deprecated v1beta1 CAPI APIs and removed linter comments everywhere. Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Apply review corrections
7e08d67 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Adjust e2e and metadata versions
3664d96 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Apply review feedback on awscluster_webhook
5169bd4 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
FIx unit tests
0d2f5dc 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Review feedback
15706dd 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Apply review feedback
b721c59 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
Add CRD RBAC to the awsmachine controller
8596a85 
Signed-off-by: Borja Clemente <bclement@redhat.com>
@chrischdi
e2e: add v1beta1 CAPI scheme to clients and adjust modifyFunc test to…
2664a38 
… use the new field name
clebs and others added 10 commits November 19, 2025 20:07
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ankitasw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@chrischdi
Copy link
Member Author

chrischdi commented Nov 20, 2025

/test help
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build 
/test pull-cluster-api-provider-aws-build-docker 
/test pull-cluster-api-provider-aws-e2e-blocking 
/test pull-cluster-api-provider-aws-test 
/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main 
/test pull-cluster-api-provider-aws-e2e 
/test pull-cluster-api-provider-aws-e2e-clusterclass 
/test pull-cluster-api-provider-aws-e2e-conformance 
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts 
/test pull-cluster-api-provider-aws-e2e-eks 
/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main 
pull-cluster-api-provider-aws-build 
pull-cluster-api-provider-aws-build-docker 
pull-cluster-api-provider-aws-e2e-blocking 
pull-cluster-api-provider-aws-test 
pull-cluster-api-provider-aws-verify
Details

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@chrischdi
Copy link
Member Author

chrischdi commented Nov 20, 2025

/test pull-cluster-api-provider-aws-e2e-clusterclass
1 similar comment
@chrischdi
Copy link
Member Author

chrischdi commented Nov 20, 2025

/test pull-cluster-api-provider-aws-e2e-clusterclass
@chrischdi
Copy link
Member Author

chrischdi commented Nov 20, 2025

/test pull-cluster-api-provider-aws-e2e-clusterclass
@chrischdi chrischdi mentioned this pull request Nov 20, 2025
Merged
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025 •
edited
Loading

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-apidiff-main 87d6860 link false /test pull-cluster-api-provider-aws-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@damdo
Copy link
Member

damdo commented Nov 20, 2025

/test pull-cluster-api-provider-aws-e2e
@damdo
Copy link
Member

damdo commented Nov 21, 2025

This gave us good signal on the e2e fix. We can close it now

/close
@damdo damdo closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

5 participants

@chrischdi @k8s-ci-robot @damdo @bryan-cox @clebs