- Notifications
You must be signed in to change notification settings - Fork 93
test: refine verify-helm-chart-index.sh #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refine verify-helm-chart-index.sh #2175
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refines the verify-helm-chart-index.sh
script to improve URL validation logic by expanding the ignore mechanism. The changes enhance the script's ability to handle URLs containing "latest" and other dynamically determined ignore patterns.
- Enhanced URL ignore logic for "latest" URLs by capturing the filename for subsequent filtering
- Added conditional logic to ignore URLs containing a previously determined ignore filename
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
/cherrypick release-1.27 |
/cherrypick release-1.26 |
/cherrypick release-1.25 |
@andyzhangx: new pull request created: #2177 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #2178 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #2179 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
test: refine verify-helm-chart-index.sh
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: