feat: allow targetGroupName instead of targetGroupARN in forward action ingress annotations

[pascal-hofmann]

Issue

#4280

Description

Allow targetGroupName instead of targetGroupARN in forward action ingress annotations

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

Welcome @pascal-hofmann!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @pascal-hofmann. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pascal-hofmann]

Hi @M00nF1sh, hi @oliviassss, hi @wweiwei-li,
it would be great to get this reviewed / merged soon. It would save us quite some manual fiddling with different ARNs in different environments.

Thanks in advance,
Pascal

[zac-nixon]

Thanks for the contribution! I left a comment around some caching which I would consider very important. The LBC already makes a lot of ELB API calls, it would be great to make sure this PR doesn't balloon the call volume.

[zac-nixon]

/ok-to-test

[zac-nixon]

/lgtm

[zac-nixon]

/retest

[zac-nixon]

/approved
/lgtm

Thank you! This looks like a great addition.

We try a monthly release cadence, so looking around September ~1st for this to be released in an official version.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pascal-hofmann, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pascal-hofmann]

Thanks for the quick feedback and merge. This was a very pleasant pull request experience. 🚀