- Notifications
You must be signed in to change notification settings - Fork 1.6k
[feat: gw-api] Creating Target Group + TGB from Gateway spec #4150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot merged 10 commits into kubernetes-sigs:main from zac-nixon:znixon/gw-tg-creation Apr 22, 2025
Merged
Changes from 8 commits
Commits
Show all changes
10 commits Select commit Hold shift + click to select a range
92eefa2 [gw api] tg creation
zac-nixon 0906738 fixes to get tg + tgb working
zac-nixon 73bda69 make logging less noisy
zac-nixon 2700a5e refactor duplicated consts
zac-nixon c4ab78b tg tests
zac-nixon 75892c3 fix interval and timeout to appease alb
zac-nixon f41f63f use shared constant for health check port
zac-nixon eab2992 refactor multicluster to target group props
zac-nixon 3476927 refactor to use route kind enum
zac-nixon caa895e infer target group type from route
zac-nixon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets infer this from the attributes value instead of creating a dedicated field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.