Skip to content

BUG FIX: fix log message when target group and cluster are in different VPCs #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024
Merged

BUG FIX: fix log message when target group and cluster are in different VPCs #3924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9259378
BUG FIX: fix log message when target group and cluster are in differe…
zac-nixon Oct 30, 2024
8427113
bump go version
zac-nixon Oct 30, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .go-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.22.7
1.22.8
4 changes: 2 additions & 2 deletions pkg/targetgroupbinding/resource_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,8 +540,8 @@ func (m *defaultResourceManager) registerPodEndpoints(ctx context.Context, tgARN
// Target group is in a different VPC from the cluster's VPC
if tgVpcID != "" && tgVpcID != m.vpcID {
vpcID = tgVpcID
m.logger.Info("registering endpoints using the targetGroup's vpcID", tgVpcID,
"which is different from the cluster's vpcID", m.vpcID)
m.logger.Info("registering endpoints using the targetGroup's vpcID", "TG VPC", tgVpcID,
"cluster's vpcID", m.vpcID)
}
vpcInfo, err := m.vpcInfoProvider.FetchVPCInfo(ctx, vpcID)
if err != nil {
Expand Down