Skip to content

restrict resolveViaVPCENIs to fargate only #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

restrict resolveViaVPCENIs to fargate only #3709

merged 1 commit into from
May 22, 2024

Conversation

@oliviassss
Copy link
Collaborator

@oliviassss oliviassss commented May 20, 2024 •
edited
Loading

Issue

Description

Restrict resolveViaVPCENIs() to fargate node only.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2024
@oliviassss oliviassss force-pushed the fargate-resolve-eni branch from 0ccb67f to c32fab0 Compare May 20, 2024 18:39
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot May 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.50000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 55.45%. Comparing base (2a66d99) to head (c32fab0).
Report is 326 commits behind head on main.

Files with missing lines Patch % Lines
pkg/networking/pod_eni_info_resolver.go 52.50% 11 Missing and 8 partials ⚠️
Additional details and impacted files 
@@ Coverage Diff @@ ## main #3709 +/- ## ========================================== - Coverage 55.47% 55.45% -0.03%  ========================================== Files 151 151 Lines 9155 9192 +37 ========================================== + Hits 5079 5097 +18  - Misses 3734 3745 +11  - Partials 342 350 +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@oliviassss
Copy link
Collaborator Author

/assign @M00nF1sh
M00nF1sh
M00nF1sh approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
TBH, this isn't ideal given the nodes are fetched multiple times.

We should clean up this code some how.
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [M00nF1sh,oliviassss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@oliviassss
Copy link
Collaborator Author

I'll merge the PR as for now, but as a TODO we need to optimize the code that node info are fetched several times in different functions.
@oliviassss oliviassss merged commit 9e9432b into kubernetes-sigs:main May 22, 2024
oliviassss added a commit to oliviassss/aws-load-balancer-controller that referenced this pull request May 30, 2024
@oliviassss
restrict resolve resolveViaVPCENIs to fargate only (kubernetes-sigs#3709
cfa85b0 
)
@oliviassss oliviassss mentioned this pull request May 30, 2024
Merged
6 tasks
oliviassss added a commit that referenced this pull request May 30, 2024
@oliviassss @larntz
@omerap12 @darkweaver87 @hyperbolic2346
cherry pick commits from main (#3727)
34353bc 
* update the traffic test for ingress (#3725) * update the traffic test for ingress * make crds * prevent controller runtime complaining about SetupLogger() was never called (#3724) * Update go to v1.22, controller-runtime dependency to v0.18.2, and kubernetes libs to v0.30.0 (#3707) * go version, dep version * refactor for controller-runtime udpate * update tests, fix if statement the controller-runtime strips DeletionTimestamp from manifests on Create(). kubernetes-sigs/controller-runtime#2316 * refactor tests * remove placeholder comments * remove reconciler from WithOptions * remove DefaultNamespace cache option * remote `&& !hasGroupFinalizer` This was causing e2e tests to fail when an ingress did not have the group finalizer. The unit tests ing-1_been_deleted, and ing-6_been_deleted will need reworked due to changes in the controller-runtime that cause them to fail. * update unit tests for ctrl client/fake >0.15 controller-runtime >=0.15 does not support creating (or adding the field via Update()) objects with a DeletionTimestamp. To work around this we add an annotation `unit-test/delete` to mark the ingresses that we want to test deletion. We check for this annotation and then call Delete(). This will set the DeletionTimestamp to the current date and time so we use IgnoreOtherFields to skip then comparing want to got. relevant controller-runtime discussion/pr: - kubernetes-sigs/controller-runtime#2184 (comment) - kubernetes-sigs/controller-runtime#2316 * remove unused contexts * add DefaultNamespaces cache config * set opt.Cache.DefaultNamespaces conditionally If WatchNamespace is set to corev1.NamespaceAll we should not set DefaultNamespaces. This code assumes that only one namespace is specified for WatchNamespace. That decision was based on the help text for the flag `watch-namespace`. Related controller-runtime issue: kubernetes-sigs/controller-runtime#2628 * make crds * set go to v1.22.3 * restrict resolve resolveViaVPCENIs to fargate only (#3709) * Added helm envFrom value parameter for cluster-name (#3683) * Added helm envFrom value parameter for cluster-name * Update README.md file * Add envFrom configuration to values.yaml * Remove empty line in values.yaml * feat: disable default helm labels (#3574) * feat: disable helm labels * fix: doc * Update README.md (#3638) Remove extra / in crds --------- Co-authored-by: Luke Arntz <luke@blue42.net> Co-authored-by: Omer Aplatony <61663422+omerap12@users.noreply.github.com> Co-authored-by: Rémi BUISSON <remi-buisson@orange.fr> Co-authored-by: Mike Wilson <hyperbolic2346@users.noreply.github.com>
@oliviassss oliviassss changed the title restrict resolve resolveViaVPCENIs to fargate only restrict resolveViaVPCENIs to fargate only May 31, 2024
@oliviassss oliviassss mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

4 participants

@oliviassss @codecov-commenter @k8s-ci-robot @M00nF1sh