update to discovery.k8s.io/v1 #3073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added cncf-cla: yes 
kishorj added tide/merge-method-squash 
k8s-ci-robot added the lgtm 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved 
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## release-2.4 #3073 +/- ## ============================================ Coverage 54.07% 54.07% ============================================ Files 144 144 Lines 8301 8301 ============================================ Hits 4489 4489 Misses 3484 3484 Partials 328 328 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kishorj force-pushed the release-2.4-discv1 branch from 61a40b7 to ba9217d Compare k8s-ci-robot added size/S set ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.20, since 2.4 branch uses go 1.19
k8s-ci-robot added the lgtm Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #3071
Description
This is the cherry pick of the fix to v2.4 branch.
Controller uses discovery.k8s.io/v1beta1, which is not supported starting k8s v1.25 release. This PR updates the controller to use discovery.k8s.io/v1. As a result, the controller will no longer support k8s 1.20 or earlier release if EndpointSlices feature is enabled via the controller flag.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯