- Notifications
You must be signed in to change notification settings - Fork 1.6k
update to discovery.k8s.io/v1 #3072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified
$ ag "k8s.io/api/discovery/v1beta1" -l controllers/elbv2/targetgroupbinding_controller.go controllers/elbv2/eventhandlers/endpointslices_test.go controllers/elbv2/eventhandlers/endpointslices.go pkg/backend/endpoint_types.go pkg/backend/endpoint_resolver_test.go pkg/backend/endpoint_resolver.go In the main branch.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #3072 +/- ## ========================================== + Coverage 54.32% 54.34% +0.02% ========================================== Files 145 145 Lines 8410 8427 +17 ========================================== + Hits 4569 4580 +11 - Misses 3511 3516 +5 - Partials 330 331 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh, orsenthil The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merge in DEL/aws-load-balancer-controller-fork from DELIVERY-8202_pull_upstream to main * commit '49805eac72ec533acdbc2580d6f57c68a9cad45c': update the default base image (kubernetes-sigs#3075) update recommended IAM policy template (kubernetes-sigs#3068) update to discovery.k8s.io/v1 (kubernetes-sigs#3072) validation ingress condition annotation in validation webhook (kubernetes-sigs#2735) Fix conciseLogger's incorrect call to variadic func (kubernetes-sigs#3066) Verify CRDs are up to date in merge check (kubernetes-sigs#3022) Refactor model builder test (kubernetes-sigs#3024)
Issue
Fixes: #3071
Description
Controller uses discovery.k8s.io/v1beta1, which is not supported starting k8s v1.25 release. This PR updates the controller to use discovery.k8s.io/v1. As a result, the controller will no longer support k8s 1.20 or earlier release if EndpointSlices feature is enabled via the controller flag.
Manual tests:
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯