Skip to content

Conversation

@johngmyers
Copy link
Contributor

Issue

#2920

Description

Adds a sslPolicy field to IngressClassParams, permitting an IngressClass to override the SSL policy for all Ingresses in the class.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟
@k8s-ci-robot k8s-ci-robot requested a review from kishorj February 4, 2023 22:45
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from M00nF1sh February 4, 2023 22:45
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.40%. Comparing base (e1fb94a) to head (aeef13e).
⚠️ Report is 633 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/model_build_listener.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #3025 +/- ## ========================================== + Coverage 54.32% 54.40% +0.07%  ========================================== Files 145 145 Lines 8410 8429 +19 ========================================== + Hits 4569 4586 +17  - Misses 3511 3512 +1  - Partials 330 331 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@johngmyers johngmyers force-pushed the ssl-policy branch 2 times, most recently from 4a64c46 to 72dbbb6 Compare February 4, 2023 22:56
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 17, 2023
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 17, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 18, 2023
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@kishorj
Copy link
Contributor

kishorj commented Mar 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1392585 into kubernetes-sigs:main Mar 3, 2023
@johngmyers johngmyers deleted the ssl-policy branch March 3, 2023 06:20
johngmyers added a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Aug 21, 2023
* Add SSLPolicy field to IngressClassParams * Fix typo Co-authored-by: Tim Bannister <tim@scalefactory.com> --------- Co-authored-by: Tim Bannister <tim@scalefactory.com>
johngmyers added a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Aug 21, 2023
Merge in DEL/aws-load-balancer-controller-fork from update-from-upstream to main * commit '9bbcc80fd4e701018636af4147b27d69e4f128d3': update ko to v0.13.0 (kubernetes-sigs#3115) update module dependencies (kubernetes-sigs#3114) added validation for dummy ports introduced in the aws-load-balancer-ssl-ports annotation (kubernetes-sigs#3067) docs: add a new page about security groups management (kubernetes-sigs#2988) Add InboundCIDRs field to IngressClassParams (kubernetes-sigs#3089) Add SSLPolicy field to IngressClassParams (kubernetes-sigs#3025) enable EndpointsFailOpen by default (kubernetes-sigs#3078)
@johngmyers johngmyers mentioned this pull request Aug 23, 2023
12 tasks
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
* Add SSLPolicy field to IngressClassParams * Fix typo Co-authored-by: Tim Bannister <tim@scalefactory.com> --------- Co-authored-by: Tim Bannister <tim@scalefactory.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

5 participants