Ability to reconfigure NLB target group health check #2967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Skipping CI for Draft Pull Request. |
k8s-ci-robot added do-not-merge/work-in-progress k8s-ci-robot added the size/L 
kishorj added tide/merge-method-squash 
| Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot added the cncf-cla: yes k8s-ci-robot added approved k8s-ci-robot removed the do-not-merge/work-in-progress 
k8s-ci-robot added the lgtm | [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
…#2967) * reconfigure NLB target group health check without deleting * use default matcher 200-399 for http health checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue
Add the ability to reconfigure NLB target group health check settings without recreating the target group.
Description
Due to limitations on the AWS NLB side, the AWS LB controller needed to delete and create a new NLB target group in case the health check settings were modified. With recent capability enhancements, the AWS NLB now allows reconfiguration of all of the target group health check attributes. This PR enables the controller to modify the NLB healthcheck configuration without having to delete the target groups.
We've introduced a feature flag
NLBHealthCheckAdvancedConfigurationwhich is set totrueby default. This feature flag can be used to revert to the legacy behavior if the NLB feature is not available in the given AZ.Manual Tests:
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯