Skip to content

Update index.md #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2023
Merged

Update index.md #2959

merged 1 commit into from
Jan 6, 2023

Conversation

@Kostavro
Copy link
Contributor

@Kostavro Kostavro commented Jan 6, 2023 •
edited
Loading

Make lists show up as lists as per MkDocs documentation.

Issue

Description

Lists were not showing up as lists.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟
@Kostavro
Update index.md
191e48d 
Make lists show up as lists as per MkDocs documentation.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 6, 2023

Hi @Kostavro. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.09%. Comparing base (5634fa2) to head (191e48d).
⚠️ Report is 654 commits behind head on main.

Additional details and impacted files 
@@ Coverage Diff @@ ## main #2959 +/- ## ======================================= Coverage 54.09% 54.09% ======================================= Files 144 144 Lines 8291 8291 ======================================= Hits 4485 4485 Misses 3479 3479 Partials 327 327

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
kishorj
kishorj approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@kishorj kishorj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@kishorj kishorj merged commit 3a98bf0 into kubernetes-sigs:main Jan 6, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, Kostavro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2023
@Kostavro Kostavro deleted the patch-1 branch January 7, 2023 07:35
@Kostavro
Copy link
Contributor Author

Kostavro commented Jan 9, 2023

Well, this accomplished nothing...
@kishorj
Copy link
Contributor

kishorj commented Jan 9, 2023

Well, this accomplished nothing...

updated the live docs, please try again
@kishorj kishorj mentioned this pull request Jan 12, 2023
Merged
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@Kostavro @Timothy-Dougherty
Update index.md (kubernetes-sigs#2959)
8cd1f30 
Make lists show up as lists as per MkDocs documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

4 participants

@Kostavro @k8s-ci-robot @codecov-commenter @kishorj