Skip to content

update external dns manifest and docs #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

update external dns manifest and docs #2895

merged 1 commit into from
Nov 24, 2022

Conversation

@kishorj
Copy link
Contributor

@kishorj kishorj commented Nov 24, 2022

Issue

External DNS example is out of date.

Description

Update external-dns sample manifest and docs.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 24, 2022
@kishorj kishorj requested a review from M00nF1sh November 24, 2022 00:50
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2022
@kishorj kishorj added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2022
M00nF1sh
M00nF1sh approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2022
@shyamjvs
Copy link

shyamjvs commented Nov 24, 2022

Nice! Thanks for making this doc change @kishorj

/lgtm
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2022

@shyamjvs: changing LGTM is restricted to collaborators

In response to this:

Nice! Thanks for making this doc change @kishorj

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Base: 54.05% // Head: 54.05% // No change to project coverage 👍

Coverage data is based on head (2a75dd1) compared to base (7367f60).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@ Coverage Diff @@ ## main #2895 +/- ## ======================================= Coverage 54.05% 54.05% ======================================= Files 144 144 Lines 8278 8278 ======================================= Hits 4475 4475 Misses 3479 3479 Partials 324 324

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
@kishorj kishorj merged commit b5e9427 into kubernetes-sigs:main Nov 24, 2022
@kishorj kishorj deleted the ext-dns-update branch December 2, 2022 22:17
@kishorj kishorj mentioned this pull request Jan 12, 2023
Merged
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@kishorj @Timothy-Dougherty
update external dns manifest and docs (kubernetes-sigs#2895)
d680b12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

5 participants

@kishorj @k8s-ci-robot @shyamjvs @codecov-commenter @M00nF1sh