- Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add default ingressclass annotation ✨ #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add default ingressclass annotation ✨ #2756
Conversation
| Welcome @meysam81! |
| Hi @meysam81. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| allowAllSecrets: false | ||
| | ||
| # whether or not this ingressclass is the default ingressclass inside the cluster | ||
| controller: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets have in this structure
# ingressClassConfig contains configurations specific to the ingress class ingressClassConfig: default: true We will group the remaining ingress class configurations under this later.
…tation' into meysam/default-ingressclass-annotation
| @kishorj done ✅ |
| /ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #2756 +/- ## ========================================== - Coverage 54.04% 54.03% -0.02% ========================================== Files 144 144 Lines 8223 8225 +2 ========================================== Hits 4444 4444 - Misses 3461 3463 +2 Partials 318 318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /lgtm |
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, meysam81 The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat: add default ingressclass annotation ✨ * bump version and add docs * modify according to peer review
Issue
Fixes: #2738
A replacement for aws/eks-charts#792
Description
Any ingressclass out there has the option to be the default ingressclass if the right value is passed to the chart. This is the reason behind this PR so that with passing a single value, we can have the ingressclass as the default inside the cluster.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯