- Notifications
You must be signed in to change notification settings - Fork 1.6k
Add docs for example of gRPC health check success codes #2700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aws-load-balancer-controller currently supports gRPC target group and ALB can checks grpc-status with health check. https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/9c79e45dd4b8cf94b97a1c6737bf1d47306460d0/pkg/ingress/model_build_target_group.go#L386-L394
|
|
| Welcome @ugwis! |
| Hi @ugwis. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| /lgtm |
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, ugwis The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…sigs#2700) aws-load-balancer-controller currently supports gRPC target group and ALB can checks grpc-status with health check. https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/9c79e45dd4b8cf94b97a1c6737bf1d47306460d0/pkg/ingress/model_build_target_group.go#L386-L394
Issue
none
Description
Add the gRPC status code to the document as health check success codes.
See also the Matcher Data Type for possible gRPC status code values.
https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_Matcher.html
aws-load-balancer-controller currently supports gRPC target group and ALB can checks grpc-status with health check.
aws-load-balancer-controller/pkg/ingress/model_build_target_group.go
Lines 386 to 394 in 9c79e45
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯