- Notifications
You must be signed in to change notification settings - Fork 1.6k
Updated run-e2e-test script to remove eksctl iamserviceaccount creation #2664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hi @cgchinmay. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@ ## main #2664 +/- ## ======================================= Coverage 53.99% 53.99% ======================================= Files 144 144 Lines 8214 8214 ======================================= Hits 4435 4435 Misses 3461 3461 Partials 318 318 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgchinmay, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @cgchinmay: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| /ok-to-test |
| /lgtm |
…on (kubernetes-sigs#2664) * Updated run-e2e-test script to remove eksctl iamserviceaccount creation * Updated run-e2e-test.sh to use service accounts created using aws cli * Updated cleanup method * Randomize Role Name * Make TestId more unique
Issue
NA
Description
Removed eksctl usage to create iamserviceaccount from run-e2e-test.sh, as in EKS Beta environment, it's not available.
Update Instance metadata and set PutHtttpResponseHopLimit as 2, now that we are adding required IAM policies directly to the NodeInstanceRole.
If we don't set response hop limit to 2, then we see following error
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯