Skip to content

Conversation

@cgchinmay
Copy link
Contributor

Issue

NA

Description

Removed eksctl usage to create iamserviceaccount from run-e2e-test.sh, as in EKS Beta environment, it's not available.
Update Instance metadata and set PutHtttpResponseHopLimit as 2, now that we are adding required IAM policies directly to the NodeInstanceRole.
If we don't set response hop limit to 2, then we see following error

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cgchinmay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2022
@k8s-ci-robot k8s-ci-robot requested review from M00nF1sh and kishorj May 25, 2022 22:06
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #2664 (81d7467) into main (d8f0a82) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## main #2664 +/- ## ======================================= Coverage 53.99% 53.99% ======================================= Files 144 144 Lines 8214 8214 ======================================= Hits 4435 4435 Misses 3461 3461 Partials 318 318 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f0a82...81d7467. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2022
Copy link
Member

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgchinmay, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@k8s-ci-robot
Copy link
Contributor

@cgchinmay: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kishorj
Copy link
Contributor

kishorj commented May 27, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2022
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 31, 2022
@kishorj
Copy link
Contributor

kishorj commented May 31, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9c79e45 into kubernetes-sigs:main May 31, 2022
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
…on (kubernetes-sigs#2664) * Updated run-e2e-test script to remove eksctl iamserviceaccount creation * Updated run-e2e-test.sh to use service accounts created using aws cli * Updated cleanup method * Randomize Role Name * Make TestId more unique
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

5 participants