Skip to content

cut v2.4.1 release #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2022
Merged

cut v2.4.1 release #2555

merged 2 commits into from
Mar 16, 2022

Conversation

@kishorj
Copy link
Contributor

@kishorj kishorj commented Mar 15, 2022

Issue

Description

cut v2.4.1 release

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2022
@kishorj kishorj requested a review from M00nF1sh March 15, 2022 22:41
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022 •
edited
Loading

Codecov Report

Merging #2555 (a94a5b8) into main (bd49f0d) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## main #2555 +/- ## ======================================= Coverage 53.85% 53.85% ======================================= Files 144 144 Lines 8165 8165 ======================================= Hits 4397 4397 Misses 3451 3451 Partials 317 317

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd49f0d...a94a5b8. Read the comment docs.
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 15, 2022
M00nF1sh
M00nF1sh approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot merged commit c4471de into kubernetes-sigs:main Mar 16, 2022
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@kishorj @Timothy-Dougherty
cut v2.4.1 release (kubernetes-sigs#2555)
70b73a4 
* cut v2.4.1 release * Helm chart for v2.4.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

4 participants

@kishorj @codecov-commenter @k8s-ci-robot @M00nF1sh