Skip to content

add documentation for manage-backend-security-group-rules #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2022
Merged

add documentation for manage-backend-security-group-rules #2486

merged 1 commit into from
Feb 8, 2022

Conversation

@kishorj
Copy link
Contributor

@kishorj kishorj commented Jan 28, 2022

Issue

Description

Add documentation for alb.ingress.kubernetes.io/manage-backend-security-group-rules annotation in the live docs.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2022
@kishorj kishorj requested a review from M00nF1sh January 28, 2022 17:24
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2022
@kishorj kishorj mentioned this pull request Jan 28, 2022
Closed
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 31, 2022
haouc
haouc approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
M00nF1sh
M00nF1sh approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haouc, kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@kishorj kishorj merged commit 8761edb into kubernetes-sigs:main Feb 8, 2022
This was referenced Feb 16, 2022
Closed
Merged
@kishorj kishorj deleted the annotation-doc branch February 18, 2022 18:42
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@kishorj @Timothy-Dougherty
add documentation for manage-backend-security-group-rules (kubernetes…
8732c8c 
…-sigs#2486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

4 participants

@kishorj @k8s-ci-robot @haouc @M00nF1sh