Skip to content

chore: clarify how to get internal NLB #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 3, 2021
Merged

chore: clarify how to get internal NLB #2356

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f66e0a9
chore: specify how to get classic nlb type
froblesmartin Nov 11, 2021
d3b8379
Move deprecation note to line start
froblesmartin Nov 12, 2021
142b3fd
add tip about provisioning internal lb
froblesmartin Nov 17, 2021
4ed06a3
fix: only nlb can be provisioned
froblesmartin Nov 17, 2021
b7e6fd2
chore: change to Internet-facing
froblesmartin Nov 30, 2021
404e84d
Update docs/guide/service/annotations.md
kishorj Dec 3, 2021
4451034
Update docs/guide/service/annotations.md
kishorj Dec 3, 2021
d302074
Update docs/guide/service/annotations.md
kishorj Dec 3, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs/guide/service/annotations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,12 @@ Traffic Routing can be controlled with following annotations:

- <a name="lb-type">`service.beta.kubernetes.io/aws-load-balancer-type`</a> specifies the load balancer type. This controller reconciles those service resources with this annotation set to either `nlb-ip` or `external`.

!!!tip
This annotation specifies the controller used to provision LoadBalancers (as specified in [legacy-cloud-provider](#legacy-cloud-provider)). Refer to [lb-scheme](#lb-scheme) to specify whether the LoadBalancer is internet-facing or internal.

!!!note ""
- For `nlb-ip` type, controller will provision NLB with IP targets. This value is supported for backwards compatibility
- For `external` type, NLB target type depend on the annotation [nlb-target-type](#nlb-target-type)
- [Deprecated] For type `nlb-ip`, the controller will provision an NLB with targets registered by IP address. This value is supported for backwards compatibility.
- For type `external`, the NLB target type depends on the [nlb-target-type](#nlb-target-type) annotation.

!!!warning "limitations"
- This annotation should not be modified after service creation.
Expand Down