Skip to content

Conversation

@tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented Oct 27, 2021

Minor chages

  • Refreshed go mod dependencies
  • Added gitignore entry for vendor dir ( exception for vendored generated files don't seem to be required anymore)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2326 (f48f599) into main (804e9af) will not change coverage.
The diff coverage is n/a.

❗ Current head f48f599 differs from pull request most recent head fa631b2. Consider uploading reports for the commit fa631b2 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## main #2326 +/- ## ======================================= Coverage 54.16% 54.16% ======================================= Files 136 136 Lines 7698 7698 ======================================= Hits 4170 4170 Misses 3212 3212 Partials 316 316 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804e9af...fa631b2. Read the comment docs.

@kishorj
Copy link
Contributor

kishorj commented Nov 1, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6c76a73 into kubernetes-sigs:main Nov 1, 2021
@tariq1890 tariq1890 deleted the minor-mod-fix branch November 1, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

4 participants