Set maximum length for custom load-balancer-name

[bnutt]

Issue

Description

AWS only allows loadbalancer names with a length up to 32 characters, this change trims the length of the provided value when a custom load balancer name is provided.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

Hi @bnutt. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kishorj]

@bnutt, thanks a bunch for your contribution. Would you be able contribute similar changes to the ALB as well?

aws-load-balancer-controller/pkg/ingress/model_build_load_balancer.go

Line 100 in a789f51

return name, nil

[bnutt]

@bnutt, thanks a bunch for your contribution. Would you be able contribute similar changes to the ALB as well?

aws-load-balancer-controller/pkg/ingress/model_build_load_balancer.go

Line 100 in a789f51

return name, nil

@kishorj Done in the commit 6e65632!

[kishorj]

/ok-to-test

[codecov-commenter]

Codecov Report

Merging #2195 (08277aa) into main (3c75edb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## main #2195 +/- ## ========================================== + Coverage 52.36% 52.39% +0.02%  ========================================== Files 133 133 Lines 7253 7257 +4 ========================================== + Hits 3798 3802 +4  Misses 3158 3158 Partials 297 297 

Impacted Files	Coverage Δ
pkg/ingress/model_build_load_balancer.go	51.96% <100.00%> (+0.42%)	⬆️
pkg/service/model_build_load_balancer.go	83.33% <100.00%> (+0.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c75edb...08277aa. Read the comment docs.

[bnutt]

/retest

[bnutt]

@kishorj I am not entirely sure if e2e tests are failing because of my changes or if it's environment related, do you have any pointers?

[kishorj]

/retest

[kishorj]

@kishorj I am not entirely sure if e2e tests are failing because of my changes or if it's environment related, do you have any pointers?

doesn't look related to your changes. I will look into it if it fails again. Could you also rebase the PR to get the recent changes?

[bnutt]

@kishorj I am not entirely sure if e2e tests are failing because of my changes or if it's environment related, do you have any pointers?

doesn't look related to your changes. I will look into it if it fails again. Could you also rebase the PR to get the recent changes?

Done.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bnutt, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kishorj]

/lgtm

[M00nF1sh]

I think we should change this logic

we shouldn't trim the LB name silently if it exceeds 32.
instead, we should validate that it matches the regex & within 32 character and error out if validation fails.

[kishorj]

I think we should change this logic

we shouldn't trim the LB name silently if it exceeds 32. instead, we should validate that it matches the regex & within 32 character and error out if validation fails.

PR #2295