Skip to content

Fixed race condition test #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2021
Merged

Fixed race condition test #1866

merged 2 commits into from
Mar 10, 2021

Conversation

@yutachaos
Copy link
Contributor

@yutachaos yutachaos commented Mar 9, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 9, 2021

Hi @yutachaos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from M00nF1sh and kishorj March 9, 2021 06:27
@yutachaos
Copy link
Contributor Author

yutachaos commented Mar 9, 2021

/assign @M00nF1sh
@M00nF1sh
Copy link
Member

M00nF1sh commented Mar 9, 2021

/ok-to-test
thanks for making this change
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2021
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 9, 2021
@yutachaos
Copy link
Contributor Author

yutachaos commented Mar 9, 2021

/retest
1 similar comment
@yutachaos
Copy link
Contributor Author

yutachaos commented Mar 9, 2021

/retest
@yutachaos @kishorj
Added go test -race option
8b8854a 
Signed-off-by: yutachaos <18604471+yutachaos@users.noreply.github.com>
@yutachaos @kishorj
Fixed the possibility of race condition when loading observedCount va…
7118ba2 
…riable. Signed-off-by: yutachaos <18604471+yutachaos@users.noreply.github.com>
@kishorj
Copy link
Contributor

kishorj commented Mar 10, 2021

@yutachaos, you will need to rebase your PR to get the recent UT fixes.
@kishorj kishorj force-pushed the feature/fixed_race_condition_test branch from e1cd93d to 7118ba2 Compare March 10, 2021 17:28
@kishorj
Copy link
Contributor

kishorj commented Mar 10, 2021

/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, yutachaos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit f3b196c into kubernetes-sigs:main Mar 10, 2021
@yutachaos yutachaos deleted the feature/fixed_race_condition_test branch March 11, 2021 02:33
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@yutachaos @Timothy-Dougherty
Fixed race condition test (kubernetes-sigs#1866)
3a1f7b3 
* Added go test `-race` option Signed-off-by: yutachaos <18604471+yutachaos@users.noreply.github.com> * Fixed the possibility of race condition when loading observedCount variable. Signed-off-by: yutachaos <18604471+yutachaos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

4 participants

@yutachaos @k8s-ci-robot @M00nF1sh @kishorj