Skip to content

Conversation

@kishorj
Copy link
Contributor

@kishorj kishorj commented Nov 19, 2020

Fixes #1673
Fix stringMap annotation type to accept values with the equal sign. For example, the following annotation will now be accepted -

alb.ingress.kubernetes.io/tags: foo=ZXF1YWxzCg==, another=tag" 

and would be parsed to

map[string]string{	"foo": "ZXF1YWxzCg==,",	"another": "tag", } 
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2020
Copy link
Member

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
nice 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kishorj, M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #1674 (66a8dca) into main (15066ef) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## main #1674 +/- ## ======================================= Coverage 46.04% 46.04% ======================================= Files 110 110 Lines 5916 5916 ======================================= Hits 2724 2724 Misses 2926 2926 Partials 266 266 
Impacted Files Coverage Δ
pkg/annotations/parser.go 88.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15066ef...66a8dca. Read the comment docs.

@M00nF1sh M00nF1sh merged commit 1def42e into kubernetes-sigs:main Nov 19, 2020
@kishorj kishorj deleted the main-stringmap branch December 24, 2020 00:37
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

4 participants