Skip to content

add event recording and ingress info in error messages #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

add event recording and ingress info in error messages #1637

merged 1 commit into from
Nov 11, 2020

Conversation

@M00nF1sh
Copy link
Member

@M00nF1sh M00nF1sh commented Nov 11, 2020 •
edited
Loading

  1. add event recording for errors and success messages to each resource.
  2. add ingress namespace/names for errors when handling individual ingress within IngressGroup.
    Fix [v2] improve the log messages #1565

Test done:

Events: Type Reason Age From Message ---- ------ ---- ---- ------- Warning FailedBuildModel 9s (x14 over 52s) ingress Failed build model due to ingress: bugbash/echo: Service "echo-sew" not found Normal SuccessfullyReconciled 2s ingress Successfully reconciled
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 11, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kishorj, M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@M00nF1sh M00nF1sh merged commit 4f0ec24 into kubernetes-sigs:main Nov 11, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@M00nF1sh @Timothy-Dougherty
add event recording and ingress info in error messages (kubernetes-si…
4668de0 
…gs#1637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

3 participants

@M00nF1sh @k8s-ci-robot @kishorj