Skip to content

Add details about secrets for ControllerModifyVolume #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add details about secrets for ControllerModifyVolume #631

wants to merge 1 commit into from
+44 −1

Conversation

@nixpanic
Copy link
Member

@nixpanic nixpanic commented Nov 14, 2025 •
edited
Loading

The secret references for ControllerModifyVolume have been added to the documentation of the StorageClass. There is also an explanation that the external-provisioner adds annotations on the PV so that the external-resizer can use them.

Marked as draft as the changes are not merged in the external-resizer/provisioner yet.

See-also: kubernetes-csi/external-resizer#544 kubernetes-csi/external-provisioner#1440
@nixpanic
Add details about secrets for ControllerModifyVolume
4235d93 
The secret references for ControllerModifyVolume have been added to the documentation of the StorageClass. There is also an explanation that the external-provisioner adds annotations on the PV so that the external-resizer can use them.
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 14, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nixpanic
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

2 participants

@nixpanic @k8s-ci-robot