Fix Quantity serialization #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added cncf-cla: yes 
| This is failing formatting check: You need to run: |
brendandburns approved these changes Nov 4, 2018
to show how V1Containers are not deserialized correctly by `Yaml.dumpAll()`. `YamlTest.testLoadAllFile()` fails.
by adding a `CustomRepresenter` for `Quantity` to `Yaml`. The serialized Deployment YAML's resource requests won't necessarily be in the same format as the original. But this PR prevents the serialization from returning empty maps which is an improvement. In the future, another PR can be made which could guarantee the original YAML is returned when serializing Deployment back to YAML.
davidxia force-pushed the fix-quantity-serialization branch from 93f1427 to 12b147c Compare | @brendanburns thanks. Fixed the formatting. |
davidxia commented Nov 4, 2018
| cpu: 500m | ||
| requests: | ||
| memory: 4Gi | ||
| cpu: '2' |
There was a problem hiding this comment.
Not sure why the quotes are here. I guess it's because QuantityFormatter.toBase10String() returns a String?
| /lgtm |
k8s-ci-robot added the lgtm 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, davidxia The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved | THanks for the PR! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix failing
YamlTest.testLoadAllFile()by adding a
CustomRepresenterforQuantitytoYaml.The serialized Deployment YAML's resource requests won't necessarily be in the
same format as the original. But this PR prevents the serialization from
returning empty maps which is an improvement.
In the future, another PR can be made which could guarantee the original YAML
is returned when serializing Deployment back to YAML.