Skip to content

Include Kubernetes 1.20 in e2e tests #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2021
Merged

Include Kubernetes 1.20 in e2e tests #875

merged 3 commits into from
Jan 12, 2021

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jan 7, 2021 •
edited
Loading

What this PR does / why we need it:
This makes sure we test against 1.20 as well. This PR also removes all manifests and tests for pre-1.17, as we do not support this anymore.

Optional Release Note:

Support Kubernetes 1.20
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2021
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2021
@xrstf xrstf requested a review from irozzo-1A January 7, 2021 13:08
@xrstf xrstf changed the title WIP - Include Kubernetes 1.20 in e2e tests Include Kubernetes 1.20 in e2e tests Jan 7, 2021
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2021
@xrstf
Copy link
Contributor Author

xrstf commented Jan 8, 2021

/retest
irozzo-1A
irozzo-1A reviewed Jan 8, 2021
View reviewed changes
test/e2e/provisioning/helper.go
semver.MustParse("v1.17.13"),
semver.MustParse("v1.18.10"),
semver.MustParse("v1.19.3"),
semver.MustParse("v1.17.16"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the test we are using K8S version 1.20, using kubelet 1.17 is out of skew policy. It should work anyway, but it's not guaranteed. We should invest some time to address this point (it can be a followup PR if is seems to work).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, we should fix this in the near future when we remove 1.17 support.
@xrstf
Copy link
Contributor Author

xrstf commented Jan 11, 2021

/retest
@xrstf
Copy link
Contributor Author

xrstf commented Jan 12, 2021

/test pull-machine-controller-e2e-aws
@irozzo-1A
Copy link
Contributor

/approve
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irozzo-1A, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@xrstf
Copy link
Contributor Author

xrstf commented Jan 12, 2021

/retest
@irozzo-1A
Copy link
Contributor

/lgtm
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a93d9295eab0103637de88b089080d649549bba
@kubermatic-bot kubermatic-bot merged commit 6a45df4 into kubermatic:master Jan 12, 2021
@xrstf xrstf deleted the kubernetes-1.20 branch January 12, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

3 participants

@xrstf @irozzo-1A @kubermatic-bot