Skip to content

Add optional use-octavia flag to OpenStack cloud config #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2021
Merged

Add optional use-octavia flag to OpenStack cloud config #870

merged 1 commit into from
Jan 13, 2021

Conversation

irozzo-1A
Copy link
Contributor

What this PR does / why we need it:
This PR adds the use-octavia flag to the OpenStack cloud config, this is a pre-requisite for:kubermatic/kubermatic#6309

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Optional Release Note:

NONE
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2020
@moadqassem
Copy link
Member

/approve
/lgtm
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f9214078cfa00c849047ba763de0fab45e7d8f5d
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irozzo-1A, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [irozzo-1A,moadqassem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@moadqassem
Copy link
Member

/retest
@moadqassem
Copy link
Member

/test pull-machine-controller-e2e-azure
@kubermatic-bot kubermatic-bot merged commit 08a4a5e into kubermatic:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

3 participants

@irozzo-1A @moadqassem @kubermatic-bot