Skip to content

Refactor the KubeVirt dns settings #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

Refactor the KubeVirt dns settings #846

merged 1 commit into from
Nov 5, 2020

Conversation

moadqassem
Copy link
Member

What this PR does / why we need it:
Refactor Kubevirt DNSConfig type from being a raw string to PodDNSConfig. This config is part of kubermatic datacenter configs.

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Follow up PR to this issue kubermatic/kubermatic#6121

Optional Release Note:

Support Kubevirt DNSConfig in Kubermatic
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 5, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2020
@moadqassem moadqassem changed the title Refactor theKubeVirt dns settings Refactor the KubeVirt dns settings Nov 5, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba314fc90d91585a1a560b7b12efe772ab8c8a07
@moadqassem
Copy link
Member Author

/test pull-machine-controller-e2e-kubevirt-dns-config
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow
@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@kron4eg
Copy link
Member

kron4eg commented Nov 5, 2020

/hold

until #847 is fixed
@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2020
@moadqassem
Copy link
Member Author

/unhold
@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2020
@moadqassem
Copy link
Member Author

/retest
@moadqassem
Refactor the kubevirt dns settings
7f31ed9 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com> Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@moadqassem moadqassem force-pushed the refactor-kubevirt-dns-configs branch from 7632b18 to 7f31ed9 Compare November 5, 2020 19:57
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2020
@moadqassem
Copy link
Member Author

@kron4eg Can I get another LGTM?
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b82aa2f4732836cd041b914822dabee7083b240d
@kubermatic-bot kubermatic-bot merged commit 7cf25b3 into master Nov 5, 2020
@kubermatic-bot kubermatic-bot deleted the refactor-kubevirt-dns-configs branch November 5, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. priority/high release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

5 participants

@moadqassem @kubermatic-bot @kubermatic-triage-bot @kron4eg @xmudrii