Use Hyperkube Kubelet for 1.18 clusters #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We already use Hyperkube Kubelet for clusters running Kubernetes 1.17 and older. This PR extends this to 1.18, as there are no Poseidon Kubelet images for the latest 1.18 releases any longer.
kubermatic-bot added release-note 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot added approved 
| /unassign @kron4eg |
xmudrii requested review from irozzo-1A and xrstf and removed request for kron4eg 
| From what I saw we have not e2e tests for k8s 1.18/1.19 probably it would be better to add them. |
kron4eg approved these changes Oct 16, 2020
| LGTM label has been added. Git tree hash: 57030e17d9776af1ecd10c19da3e90560f132b0c |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We already use Hyperkube Kubelet for clusters running Kubernetes
1.17 and older. This PR extends this to 1.18, as there are no
Poseidon Kubelet images for the latest 1.18 releases any longer.
Optional Release Note:
/assign @kron4eg