Add enableBootDiagnostics field to Azure cloud spec #1438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot added kind/feature Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot added the sig/cluster-management 
| /retest |
| LGTM label has been added. Git tree hash: 9f2a117cc76bc806f25efc45051cccf2846e448f |
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, embik The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot added the approved Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Boot diagnostics are nice because you can see the console logs if things go wrong and you cannot SSH into your VM for whatever reason. That can be useful for our development, but I imagine users who face stability issues with their Azure VMs might also want to enable this setting.
Azure enables this setting by default on VMs created via the portal, so it seems a good idea to at least provide a setting for this.
Which issue(s) this PR fixes:
Fixes #1291
What type of PR is this?
/kind feature
/kind api-change
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: