Skip to content

Conversation

@zwindler
Copy link

Trying to apply this manifest will fail

You can create buckets in MinIO with "/" in them, only lowercase letters, numbers dots and hyphens

I tried to reproduce on the MinIO UI, which is more verbose

image

Signed-off-by: Denis GERMAIN <dt.germain@gmail.com>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2024
@kubermatic-bot
Copy link
Contributor

Hi @zwindler. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ahmedwaleedmalik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@embik
Copy link
Member

embik commented Oct 17, 2024

Hey, thanks for the contribution! I haven't looked at why this might be failing yet, but the mc mb documentation is pretty clear on this:

For creating a bucket on MinIO, specify the alias and the name of the bucket. For example:

mc mb play/mybucket 

src is not part of the bucket name here, but it's the alias for the MinIO server. You don't need this when interacting with MinIO directly via its UI, of course.

Have you verified that this actually creates a bucket and not a local directory?

@embik
Copy link
Member

embik commented Oct 17, 2024

/hold

to clarify.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2024
@embik
Copy link
Member

embik commented Oct 17, 2024

I suspect maybe that the host add command no longer serves as an alias, so src is no longer recognised as the target MinIO ...

@zwindler
Copy link
Author

zwindler commented Oct 17, 2024

Well, I tear down my test cluster but as I recall job kept failing when I tried running it when installing KKP 1.25.11

I should have kept the error messages but I don't think I did... I'll have to create a new cluster to try again

@embik
Copy link
Member

embik commented Oct 17, 2024

Well, I tear down my test cluster but as I recall job kept failing when I tried running it when installing KKP 1.25.11

I should have kept the error messages but I don't think I did... I'll have to create a new cluster to try again

All good, we can also investigate. I don't doubt it's failing, I was just very surprised to see this as a solution because my understanding of the tool (so far) was that it would just create a local directory. I could be wrong there though!

@embik
Copy link
Member

embik commented Oct 17, 2024

Hm, I cannot reproduce any error unfortunately. I've changed it to src/test-marvin-please-ignore to make sure I'm creating a new bucket, but the log output looks fine:

$ k logs create-minio-backup-bucket-3-ct5gs Added `src` successfully. Bucket created successfully `src/test-marvin-please-ignore`.

It would be interesting to see the errors you've encountered.

@zwindler
Copy link
Author

Interesting, I'll try again. Thanks

@zwindler
Copy link
Author

Ok, I tried again and I can't reproduce. I don't know what happened nor why I though changing the command fixed it. Sorry for the time you lost on this

@zwindler zwindler closed this Oct 18, 2024
@embik
Copy link
Member

embik commented Oct 18, 2024

Ok, I tried again and I can't reproduce. I don't know what happened nor why I though changing the command fixed it. Sorry for the time you lost on this

No worries at all! We appreciate the spirit of contribution. Perhaps MinIO wasn't up yet and that produced a confusing error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

3 participants