use objectMapperForSerialization for kotlin type classes #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| Not sure why sonar is failing , @jxnu-liguobin can you please help. I think forked repo by default doesn't copy develop branch and we tend to create working branch from master which doesn't have develop under .git/refs/head |
Collaborator
Usually we do not need to care about soar. |
Contributor Author
Okay , in that case can you please review and merge if changes looks ok. |
jxnu-liguobin approved these changes Sep 5, 2022
Contributor Author
| @kobylynskyi Can you please review and merge |
Collaborator
He's probably still sleeping 😄 . |
kobylynskyi approved these changes Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Related to #995
Changes were made to: