This repository was archived by the owner on Jan 24, 2024. It is now read-only.
feat(feed): add support customizing the badge count and open behavior #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cjbell requested review from brentjanderson, juanazam, meryldakin and thomaswhyyou 
thomaswhyyou reviewed Jun 7, 2022
brentjanderson approved these changes Jun 7, 2022
thomaswhyyou approved these changes Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds support for 2 new options:
badgeCountTypeon theNotificationIconButtonandUnseenBadge: allows the behavior of what count is displayed on the badge to be customized. The supported options are"unseen" | "unread" | "all".onOpenon theNotificationFeedPopover: allows a custom function to be passed that will be invoked each time the feed is opened. This defaults to the existing behavior of marking all unseen items as "seen" but the behavior can now be customized so that items can be marked as read, or archived once a feed is shown.Note: we previously changed the visibility on the
NotificationFeed, but this actually made no sense as theNotificationFeednever needed to know about visibility beyond changing the status. I moved the behavior to theNotificationFeedPopoveras the popover itself needs to understand the visible state.Welcome to feedback!
Internal task