Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

fix: add children prop to KnockFeedProvider #13

Merged
merged 1 commit into from
May 5, 2022
Merged

fix: add children prop to KnockFeedProvider #13

merged 1 commit into from
May 5, 2022

Conversation

@juanazam
Copy link
Contributor

@juanazam juanazam commented May 4, 2022

When adding children to KnockFeedProvider the following typescript error is shown.

 Type '{ children: Element; host: string | undefined; apiKey: string; feedId: string; userId: string; }' is not assignable to type 'IntrinsicAttributes & KnockFeedProviderProps'. Property 'children' does not exist on type 'IntrinsicAttributes & KnockFeedProviderProps'.
@juanazam juanazam force-pushed the fix/support_children_on_provider_component branch from be71f00 to 8a1657e Compare May 4, 2022 04:28
cjbell
cjbell approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@cjbell cjbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks for fixing!
@juanazam juanazam mentioned this pull request May 4, 2022
Merged
@juanazam juanazam merged commit 6b6a913 into main May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@juanazam @cjbell