Skip to content

Conversation

@dprotaso
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2024
@knative-prow knative-prow bot requested review from krsna-m and skonto January 14, 2024 15:20
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2024
@codecov
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5b1f5c) 81.54% compared to head (cadb819) 81.54%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #1237 +/- ## ======================================= Coverage 81.54% 81.54% ======================================= Files 19 19 Lines 1669 1669 ======================================= Hits 1361 1361 Misses 220 220 Partials 88 88 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2024
@dprotaso
Copy link
Contributor Author

/retest

Copy link
Contributor

@andrew-su andrew-su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@knative-prow
Copy link

knative-prow bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrew-su, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabo1208
Copy link

/test latest-mesh

@knative-prow knative-prow bot merged commit fac811c into knative-extensions:main Jan 15, 2024
@dprotaso dprotaso deleted the bump-istio branch January 15, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

3 participants