Skip to content

Conversation

@jaybuidl
Copy link
Member

@jaybuidl jaybuidl commented Apr 25, 2023

recreated because #252 was not compatible anymore.

Breaking changes

  • KlerosCore.executeDelayedStakes() has moved to SortitionModule.executeDelayedStakes()
  • DisputeKit.phase and KlerosCore.phase merged into a single SortitionModule.phase with the freezing phase from KlerosCore mapping to both the generating and drawing phases from the DisputeKit.
  • The event DisputeKit.NewPhaseDisputeKit is removed, use ISortitionModule.NewPhase instead.
  • These state variables have been moved from DisputeKit to SortitionModule
 RNG public rng; uint256 public rngRequestedBlock; uint256 public rngLookahead; uint256 public randomNumber; Phase public phase; uint256 public disputesWithoutJurors; 
  • The event KlerosCore.NewPhase is removed, use ISortitionModule.NewPhase instead.
  • These state variables have been moved from KlerosCore to SortitionModule
 Phase public phase; uint256 public minStakingTime; uint256 public maxFreezingTime; uint256 public lastPhaseChange; uint256 public freezeBlock; uint256[] public disputesKitIDsThatNeedFreezing; mapping(uint256 => DelayedStake) public delayedStakes; uint256 public delayedStakeWriteIndex; uint256 public delayedStakeReadIndex = 1; 
  • The SortitionSumTreeFactoryV2 library has been removed, it is superseded by the SortitionModule.
  • The last parameter newTotalStake of the event StakeSet has been removed.
  • The view function KlerosCore.getJurorBalance() returns 3 variables instead of 2.

Ops

When deploying a new SortitionModule, it is the deployer's responsibility to ensure that createTree() has been called for each court, before associating this SortitionModule with any court.

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 1c2327b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/64485bcbc11940000882c9bc
😎 Deploy Preview https://deploy-preview-782--kleros-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jaybuidl jaybuidl force-pushed the feat/sortition-modularity-bis branch 2 times, most recently from b6a24e3 to 7de0aca Compare April 25, 2023 21:51
@jaybuidl jaybuidl force-pushed the feat/sortition-modularity-bis branch from 7de0aca to eef26c4 Compare April 25, 2023 21:54
@jaybuidl jaybuidl force-pushed the feat/sortition-modularity-bis branch from eef26c4 to 970d63a Compare April 25, 2023 21:57
@jaybuidl jaybuidl force-pushed the feat/sortition-modularity-bis branch from 970d63a to d84b541 Compare April 25, 2023 21:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@jaybuidl jaybuidl linked an issue Apr 25, 2023 that may be closed by this pull request
@jaybuidl jaybuidl added this to the alpha-1 milestone Apr 25, 2023
@jaybuidl jaybuidl merged commit 1c2327b into dev Apr 25, 2023
@jaybuidl jaybuidl deleted the feat/sortition-modularity-bis branch April 25, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants