Skip to content

feat(KC): allow to pass commit period quicker #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
+10 −3
Merged

feat(KC): allow to pass commit period quicker #2196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions contracts/src/arbitration/KlerosCore.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,8 +708,10 @@ contract KlerosCore is IArbitratorV2, Initializable, UUPSProxiable {
if (round.drawnJurors.length != round.nbVotes) revert DisputeStillDrawing();
dispute.period = court.hiddenVotes ? Period.commit : Period.vote;
} else if (dispute.period == Period.commit) {
// Note that we do not want to pass to Voting period if all the commits are cast because it breaks the Shutter auto-reveal currently.
if (block.timestamp - dispute.lastPeriodChange < court.timesPerPeriod[uint256(dispute.period)]) {
if (
block.timestamp - dispute.lastPeriodChange < court.timesPerPeriod[uint256(dispute.period)] &&
!disputeKits[round.disputeKitID].areCommitsAllCast(_disputeID)
) {
revert CommitPeriodNotPassed();
}
dispute.period = Period.vote;
Expand Down
7 changes: 6 additions & 1 deletion contracts/test/foundry/KlerosCore_Voting.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ contract KlerosCore_VotingTest is KlerosCore_TestBase {
voteIDs[0] = 1;
voteIDs[1] = 2;

// Shouldn't allow to switch period yet.
vm.expectRevert(KlerosCore.CommitPeriodNotPassed.selector);
core.passPeriod(disputeID);

vm.prank(staker1);
vm.expectEmit(true, true, true, true);
emit DisputeKitClassicBase.CommitCast(disputeID, staker1, voteIDs, commit);
Expand All @@ -109,7 +113,8 @@ contract KlerosCore_VotingTest is KlerosCore_TestBase {
}

// Check reveal in the next period
vm.warp(block.timestamp + timesPerPeriod[1]);
// Should allow to switch period since all commits are cast.
//vm.warp(block.timestamp + timesPerPeriod[1]);
core.passPeriod(disputeID);

// Check the require with the wrong choice and then with the wrong salt
Expand Down
Loading