Skip to content

No more Neo contract distinction #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 4, 2025
Merged

No more Neo contract distinction #2126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
63744e9
feat: added a arbitrableWhitelistEnabled flag to KlerosCoreNeo
jaybuidl Sep 4, 2025
262f940
feat: allow jurorNft to be address(0) which disables gating
jaybuidl Sep 4, 2025
bd210be
feat: only KlerosCore, no more KlerosCoreBase and KlerosCoreNeo
jaybuidl Sep 4, 2025
40714da
feat: only SortitionModule, no more SortitionModuleBase and Sortition…
jaybuidl Sep 4, 2025
758a809
test: extra init asserts in foundry tests
jaybuidl Sep 4, 2025
7a5d08d
fix: hardhat tests, deploy scripts, unnecessary virtual keyword
jaybuidl Sep 4, 2025
e9f8a0a
refactor: renamed 00-home-chain-arbitration-neo into 00-home-chain-ar…
jaybuidl Sep 4, 2025
923bd7b
chore: removed traces of Neo in many scripts and filenames
jaybuidl Sep 4, 2025
daa8bf9
chore: removed traces of Neo in more scripts
jaybuidl Sep 4, 2025
4e384c9
chore: updated audit METRICS files
jaybuidl Sep 4, 2025
8636c23
chore: rename of the arbitrum contract artifacts, no more Neo suffix …
jaybuidl Sep 4, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: extra init asserts in foundry tests
  • Loading branch information
@jaybuidl
jaybuidl committed Sep 4, 2025
commit 758a809a6237ed2d171adb214b23a6c629a64613
10 changes: 8 additions & 2 deletions contracts/test/foundry/KlerosCore_Initialization.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ contract KlerosCore_InitializationTest is KlerosCore_TestBase {
assertEq(core.isSupported(GENERAL_COURT, NULL_DISPUTE_KIT), false, "General court null dk should be false");
assertEq(core.isSupported(GENERAL_COURT, DISPUTE_KIT_CLASSIC), true, "General court classic dk should be true");
assertEq(core.paused(), false, "Wrong paused value");
assertEq(core.wNative(), address(wNative), "Wrong wNative");
assertEq(address(core.jurorNft()), address(0), "Wrong jurorNft");
assertEq(core.arbitrableWhitelistEnabled(), false, "Wrong arbitrableWhitelistEnabled");

assertEq(pinakion.name(), "Pinakion", "Wrong token name");
assertEq(pinakion.symbol(), "PNK", "Wrong token symbol");
Expand All @@ -71,6 +74,9 @@ contract KlerosCore_InitializationTest is KlerosCore_TestBase {
assertEq(sortitionModule.randomNumber(), 0, "randomNumber should be 0");
assertEq(sortitionModule.delayedStakeWriteIndex(), 0, "delayedStakeWriteIndex should be 0");
assertEq(sortitionModule.delayedStakeReadIndex(), 1, "Wrong delayedStakeReadIndex");
assertEq(sortitionModule.maxStakePerJuror(), type(uint256).max, "Wrong maxStakePerJuror");
assertEq(sortitionModule.maxTotalStaked(), type(uint256).max, "Wrong maxTotalStaked");
assertEq(sortitionModule.totalStaked(), 0, "Wrong totalStaked");

(uint256 K, uint256 nodeLength) = sortitionModule.getSortitionProperties(bytes32(uint256(FORKING_COURT)));
assertEq(K, 5, "Wrong tree K FORKING_COURT");
Expand Down Expand Up @@ -129,8 +135,8 @@ contract KlerosCore_InitializationTest is KlerosCore_TestBase {
newMinStakingTime,
newMaxDrawingTime,
newRng,
type(int256).max,
type(int256).max
type(uint256).max,
type(uint256).max
);

UUPSProxy proxySm = new UUPSProxy(address(smLogic), initDataSm);
Expand Down
4 changes: 2 additions & 2 deletions contracts/test/foundry/KlerosCore_TestBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ abstract contract KlerosCore_TestBase is Test {
minStakingTime,
maxDrawingTime,
rng,
type(int256).max,
type(int256).max
type(uint256).max,
type(uint256).max
);

UUPSProxy proxySm = new UUPSProxy(address(smLogic), initDataSm);
Expand Down
Loading