fix(DK): no empty addresses after draw #2060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for kleros-v2-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for kleros-v2-neo failed. Why did it fail? →
|
❌ Deploy Preview for kleros-v2-university failed. Why did it fail? →
|
WalkthroughA zero-address check was added to the juror drawing logic in the dispute kit contract, ensuring that post-draw validation is only performed for non-zero addresses. Additionally, a new test was introduced to verify that no empty addresses are drawn when no jurors are staked. Changes
Sequence Diagram(s)sequenceDiagram participant User participant DisputeKit participant SortitionModule User->>DisputeKit: draw() DisputeKit->>SortitionModule: draw() SortitionModule-->>DisputeKit: drawnAddress alt drawnAddress != address(0) DisputeKit->>DisputeKit: _postDrawCheck(drawnAddress) alt _postDrawCheck passes DisputeKit->>DisputeKit: Add vote, mark address as drawn else _postDrawCheck fails DisputeKit->>DisputeKit: Reset drawnAddress to zero end else drawnAddress == address(0) DisputeKit->>DisputeKit: Skip post-draw check, return zero end Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
✅ Deploy Preview for kleros-v2-testnet-devtools ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jaybuidl approved these changes Aug 1, 2025
|
This was referenced Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the
DisputeKitClassicBaseby adding a check to handle cases where no addresses are drawn due to lack of stakes, along with a new test to ensure that empty addresses are not returned during the drawing phase.Detailed summary
DisputeKitClassicBase.solto returndrawnAddressif it isaddress(0).test_draw_noEmptyAddressesinKlerosCore.t.solto verify that no empty addresses are drawn when no one has staked.nbVotersis0in the new test.Summary by CodeRabbit
Bug Fixes
Tests