- Notifications
You must be signed in to change notification settings - Fork 50
fix(kleros-app): add-state-for-confirm-email #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new state variable, Changes
Sequence Diagram(s)sequenceDiagram participant User participant AtlasProvider participant EmailService User->>AtlasProvider: confirmEmail() AtlasProvider->>AtlasProvider: set isConfirmingEmail = true AtlasProvider->>EmailService: Send confirmation request EmailService-->>AtlasProvider: Response AtlasProvider->>AtlasProvider: set isConfirmingEmail = false AtlasProvider-->>User: Confirmation result, isConfirmingEmail status Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
✅ Deploy Preview for kleros-v2-testnet-devtools ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for kleros-v2-university failed. Why did it fail? →
|
✅ Deploy Preview for kleros-v2-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for kleros-v2-neo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alcercu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
86c7a17 to dd9f9c3 Compare | Code Climate has analyzed commit bfd18da and detected 0 issues on this pull request. View more on Code Climate. |
|



PR-Codex overview
This PR updates the
versionof the@kleros/kleros-apppackage and introduces a new state variableisConfirmingEmailin theAtlasProvider. It modifies the email confirmation logic to manage the new state, enhancing user feedback during the email confirmation process.Detailed summary
versionfrom2.1.0to2.1.1inpackage.json.isConfirmingEmailstate variable inAtlasProvider.isConfirmingEmailtotruewhen confirming email and back tofalsein thefinallyblock.isConfirmingEmailin the provider's context value.Summary by CodeRabbit