feat(web): mobile view top jurors and some refactors #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kemuru changed the title kemuru added Type: Enhancement ✨ Package: Web 
alcercu reviewed Oct 30, 2023
alcercu reviewed Oct 30, 2023
alcercu reviewed Oct 30, 2023
alcercu reviewed Oct 30, 2023
alcercu reviewed Oct 30, 2023
alcercu reviewed Oct 30, 2023
alcercu reviewed Oct 30, 2023
alcercu reviewed Oct 30, 2023
alcercu reviewed Oct 30, 2023
alcercu suggested changes Oct 30, 2023
Contributor
alcercu left a comment
alcercu left a comment There was a problem hiding this comment.
Resolve rest of comments
… github.com:kleros/kleros-v2 into feat(web)/mobile-view-top-jurors-and-some-refactors
| Kudos, SonarCloud Quality Gate passed!
|
| Code Climate has analyzed commit d4f554b and detected 15 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jaybuidl approved these changes Oct 30, 2023
jaybuidl deleted the feat(web)/mobile-view-top-jurors-and-some-refactors branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
One thing to note is I created MobileCard.tsx and DesktopCard.tsx (because the components had different structures between desktop and mobile versions). Lmk what you think (we did the same with Navbar IIRC).
PR-Codex overview
This PR focuses on updating the TopJurors component in the Home page.
Detailed summary