- Notifications
You must be signed in to change notification settings - Fork 50
Subgraph notification #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subgraph notification #1282
Conversation
❌ Deploy Preview for kleros-v2 failed.
|
| note, I removed jump from the classicDisputeKit entity. We can put it back, but the jump property was never properly updated. I tried to properly update the jump property, but the potential solutions seem complicated. In fact, the jump property should be abstracted into the DisputeKitDispute interface. From the perspective of the Dispute entity (core dispute), it tracks DisputeKitDisputes, but, since each ClassicDispute extends the DisputeKitDispute interface, we cannot load a generic DisputeKitDispute entity from a core dispute id. A solution would be to use a switch case loader utility function to handle each entity type for new dispute kits. This appeared to be too much complexity so I just removed the field "jump" for now. If the frontend is relying on this parameter, we can put it back, but it was hardcoded as "false". |
| Code Climate has analyzed commit 7cce1c7 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| Kudos, SonarCloud Quality Gate passed!
|








This PR adds features to the subgraph to support polling notification systems.
PR-Codex overview
This PR focuses on adding new functionality related to court jumps and period index counters.
Detailed summary
user.roundsarray toUserentity inUser.tsclassicDispute.jumpedproperty inClassicDispute.tshandleCourtJumpevent handler insubgraph.yamlgetAndIncrementPeriodCounterfunction inPeriodIndexCounter.tsuseClassicAppealQueryanduseDrawQueryhooks inuseClassicAppealQuery.tsanduseDrawQuery.tsgetLocalRoundsfunction ingetLocalRounds.tsDisputeCard/index.tsx,useClassicAppealContext.tsx,Overview.tsx,Voting/index.tsx,CaseDetails/VotingHistory.tsx, andKlerosCore.tshandleCourtJumpevent handler inKlerosCore.ts