fix(mapping): json parse and null errors #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Kudos, SonarCloud Quality Gate passed!
|
| Merging is blocked due to CI/CD |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
json parsing errors broke the mapping. Replaced the json parsing with a safe version that returns a success boolean to safely handle errors.
also fixed some issues due to a parameter of the Round struct left null.
Here's the current subgraph deployment for goerli.
I only tested the change on goerli.
Maybe green can review and test the PR for ethereum and gnosis when he's back, otherwise the subgraphs on Ethereum and Gnosis aren't broke, so maybe no need to update those.