feat(json-api-nestjs): Uuid support for relationships #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
klerick reviewed Mar 31, 2023
| I believe this should be good now, @klerick. Please take another look. |
klerick approved these changes Apr 3, 2023
| 🎉 This pull request is included in version json-api-nestjs@4.2.10 🎉 The release is available on GitHub release |
| 🎉 This pull request is included in version json-api-nestjs-sdk@5.0.0 🎉 The release is available on GitHub release |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #40.
@klerick please take a look at my new approach based on your suggestion. Let me know if we can further improve it.
Also, I've had a little trouble making an unit test because(nvm, working on that)pg-memdoesn't seem to supportuuidout of the box. Any ideas on how to solve that?