Skip to content

Conversation

@saurabh-23232
Copy link

@saurabh-23232 saurabh-23232 commented Oct 18, 2024

Developer Checklist

  • Adhered to the guidelines outlined in the README & Contributing file.
  • Maintained the correct directory structure (e.g., ProjectName/...yourfiles).
  • Please ensure to include a README file for enhanced project clarity.
  • Starred ⭐ the repository (optional).

Summary

Please provide a brief summary here.

Screenshot

Attach any relevant screenshots or GIFs here.

Live Project Link

Include a link to the live project here.
@saurabh-23232
Copy link
Author

@king04aman Its my first contribution can u help me how to fix this issue

Copy link
Owner

@king04aman king04aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Organize all project files into a single directory for better structure.
  • Submit each project in its own PR. Please create a separate PR for the movie scraper.
  • Complete the developer checklist items before resubmitting the PR.
  • Ensure sensitive data like API keys are not hardcoded in the source files.
  • Add detailed documentation for functions to clarify their purpose and usage.
  • Implement better error handling across all files to improve stability.
  • Use more descriptive variable names, especially for X, y, and data, to improve code readability.
@king04aman
Copy link
Owner

Hi @saurabh-23232 ,

I wanted to check in regarding the feedback provided in the last review. Do you have any updates on the changes? I’m looking forward to your progress!

@saurabh-23232
Copy link
Author

Hi @saurabh-23232 ,

I wanted to check in regarding the feedback provided in the last review. Do you have any updates on the changes? I’m looking forward to your progress!

please tell me what I did wrong above which make it all checks have failed? any resources you can share so i can rectify it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants