This repository was archived by the owner on Feb 4, 2023. It is now read-only.
Fixed linker errors when included in multiple .cpp files #1
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi,
I was using your library in my project, and when I started including your .h files in multiple .cpp files (compile units), the linker started complaining, as all your symbols where exported from multiple .o files.
I moved your implementations into .cpp files, which allows for linkage instead of inlining, which should not affect performance much.