Jeesparza dev #33
Closed
Jeesparza dev #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Removed static constructor, and instantiated static variables by themselves. - Removed redundant variables - Refactored code to make it more readable - Removed setTriggerContext method by using out of the box enumerator - Removed nested enumerator class
Fixed class to cover changes made to main class on Logic Redux Change. Removed unnecessary comments.
dschach reviewed Nov 21, 2022
| private static Map<String, LoopCount> loopCountByTrigerHandlerName = new Map<String, LoopCount>(); | ||
| private static Set<String> bypassedHandlers = new Set<String>(); | ||
| | ||
| public TriggerHandler(System.TriggerOperation triggerEvent) { |
There was a problem hiding this comment.
@jeesparza2 It looks like you're requiring passing in the trigger event each time - changing the constructor. This is a breaking change, so nobody can update code to use the latest version if your PR is merged and they copy/paste your code over existing code.
Perhaps you can add your constructor as another option but leave the old code - that way it's not a breaking change.
Please also update documentation. There is a readme file and some other documentation.
(Shameless plug: If you'd like to do that on my repo, I'd include your additional constructor in that. https://github.com/dschach/salesforce-trigger-framework)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi Kevin, came across this class in one of my client's projects. Noticed that the logic could be reduced slightly by using out of the box variables. Hope this helps, and thanks for the great framework.