This repository was archived by the owner on Sep 18, 2024. It is now read-only.
Remove unused pandas import #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
4 tasks
| @rragundez Will there be a minor release after this fix? |
Contributor Author
| I'm trying to get that arranged indeed. In my opinion it must happen as this can break many people's import statements. I'll try to get back to you ASAP. |
| a minor release would be great, this breaks the tensorflow pypi package as well when using keras |
jantonguirao added a commit to jantonguirao/DALI that referenced this pull request Jan 30, 2019
…porting pandas, which is not installed) Reference: keras-team/keras-preprocessing#154 keras-team/keras-preprocessing#156 Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao added a commit to NVIDIA/DALI that referenced this pull request Jan 30, 2019
…porting pandas, which is not installed) (#498) Reference: keras-team/keras-preprocessing#154 keras-team/keras-preprocessing#156 Signed-off-by: Joaquin Anton <janton@nvidia.com>
Dref360 approved these changes Jan 30, 2019
haoxintong pushed a commit to haoxintong/DALI that referenced this pull request Jul 16, 2019
…porting pandas, which is not installed) (NVIDIA#498) Reference: keras-team/keras-preprocessing#154 keras-team/keras-preprocessing#156 Signed-off-by: Joaquin Anton <janton@nvidia.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
At the moment there is an unused pandas import. This is also the only import of pandas in the source code which makes the import of the package break if the user hasn't pandas installed. This PR removes the import.
Related Issues
#154
PR Overview