Skip to content

Conversation

MaksimDrobchak
Copy link
Contributor

@MaksimDrobchak MaksimDrobchak commented Feb 22, 2019

added opportunity to copy selected items to system buffer

filteredItems: items
};

this.refCmponent = React.createRef();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Copy link

@johanzilber johanzilber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add it to readme?

@MaksimDrobchak
Copy link
Contributor Author

@johanzilber
Sure, done.

@liorheber
Copy link
Collaborator

Hi,

the problem with this solution is that it mandates that an item has a label which is not the case.
You should have the ability to customize the copy method (with documentation) otherwise you break the component for some.
Additionally, I would consider giving the ability yo toggle the feature off for people who are not yet ready to migrate to this feature.

@MaksimDrobchak
Copy link
Contributor Author

@liorheber
Sure, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants