Skip to content

Conversation

@jakezhu9
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references:

  • N
  • Y

part of kcl-lang/kcl#526

2. What is the scope of this PR (e.g. component or file name):

pkg/tools/gen

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Add the feature to generate kcl schema from terraform provider schema. We can use the command terraform providers schema -json > provider.json to get detailed schemas for the providers used in the current terraform configuration . And use GenKcl function to generate kcl schema. The result covers all resource schemas in the file, similar to the base.pkg.kusion_clouds.alicloud and base.pkg.kusion_clouds.aws in konfig.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
@Peefy Peefy added the tool label Aug 22, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

@Peefy Peefy merged commit c38d105 into kcl-lang:main Aug 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2 participants